Lindenii Project Forge
Login

server

Lindenii Forge’s main backend daemon
Commit info
ID
3355827fb55a22d9b8064ab55c5f26650f1b1148
Author
Runxi Yu <me@runxiyu.org>
Author date
Sat, 15 Mar 2025 15:05:12 +0800
Committer
Runxi Yu <me@runxiyu.org>
Committer date
Sat, 15 Mar 2025 15:05:12 +0800
Actions
Fix memory leak in segments_from_path again

Use freeall on a sub-slice instead of looping; previous behavior also
leaks the memory used by the sp slice itself.
// SPDX-License-Identifier: AGPL-3.0-only
// SPDX-FileCopyrightText: Copyright (c) 2025 Runxi Yu <https://runxiyu.org>

use strings;
use net::uri;

// The result must be freed with strings::freeall.
// The result, if not erroring out, must be freed with strings::freeall.
fn segments_from_path(s: str) ([]str | nomem | uri::invalid) = {
	let sp: []str = strings::split(s, "/")?;
	for (let i = 1z; i < len(sp); i += 1) {
		match (uri::percent_decode(sp[i])) {
		case let s: str =>
			sp[i - 1] = s;
		case uri::invalid =>
			for (let j = 0z; j < i - 1; j += 1) {
				free(sp[j]);
			};
			strings::freeall(sp[.. i - 1]);
			return uri::invalid;
		};
	};
	return sp[.. len(sp) - 1];
};