From 811d91cbb731f7c824e870f5b606ee67d0e74dd4 Mon Sep 17 00:00:00 2001
From: Runxi Yu <me@runxiyu.org>
Date: Tue, 11 Feb 2025 20:01:02 +0800
Subject: [PATCH] *.go: Linting

---
 git_misc.go      |  8 ++++----
 render_readme.go | 10 +++-------

diff --git a/git_misc.go b/git_misc.go
index 01e1191298d2d9cff4255bb60d8b389ae649ee67..851fb683f03ed66ce924dea9170edfa7975994c8 100644
--- a/git_misc.go
+++ b/git_misc.go
@@ -49,7 +49,7 @@ }
 
 var err_get_recent_commits = errors.New("Error getting recent commits:")
 
-func get_recent_commits(repo *git.Repository, head_hash plumbing.Hash, n int) (recent_commits []*object.Commit, err error) {
+func get_recent_commits(repo *git.Repository, head_hash plumbing.Hash, number_of_commits int) (recent_commits []*object.Commit, err error) {
 	commit_iter, err := repo.Log(&git.LogOptions{From: head_hash})
 	if err != nil {
 		err = misc.Wrap_one_error(err_get_recent_commits, err)
@@ -57,7 +57,7 @@ 		return nil, err
 	}
 	recent_commits = make([]*object.Commit, 0)
 	defer commit_iter.Close()
-	if n < 0 {
+	if number_of_commits < 0 {
 		for {
 			this_recent_commit, err := commit_iter.Next()
 			if errors.Is(err, io.EOF) {
@@ -69,7 +69,7 @@ 			}
 			recent_commits = append(recent_commits, this_recent_commit)
 		}
 	} else {
-		for range n {
+		for range number_of_commits {
 			this_recent_commit, err := commit_iter.Next()
 			if errors.Is(err, io.EOF) {
 				return recent_commits, nil
@@ -80,5 +80,5 @@ 			}
 			recent_commits = append(recent_commits, this_recent_commit)
 		}
 	}
-	return
+	return recent_commits, err
 }
diff --git a/render_readme.go b/render_readme.go
index fd9d5e7bd792e02f22d5f8353bfa8250e01e74ff..72e0ec4585fd688ad08dbcbf1c071f4cb414de0a 100644
--- a/render_readme.go
+++ b/render_readme.go
@@ -10,6 +10,8 @@ 	"github.com/yuin/goldmark"
 	"github.com/yuin/goldmark/extension"
 )
 
+var markdown_converter = goldmark.New(goldmark.WithExtensions(extension.GFM))
+
 func render_readme_at_tree(tree *object.Tree) any {
 	readme_file, err := tree.File("README.md")
 	if err != nil {
@@ -20,14 +22,8 @@ 	if err != nil {
 		return "Unable to fetch contents of README: " + err.Error()
 	}
 
-	md := goldmark.New(
-		goldmark.WithExtensions(
-			extension.GFM,
-		),
-	)
-
 	var readme_rendered_unsafe bytes.Buffer
-	err = md.Convert([]byte(readme_file_contents), &readme_rendered_unsafe)
+	err = markdown_converter.Convert([]byte(readme_file_contents), &readme_rendered_unsafe)
 	if err != nil {
 		return "Unable to render README: " + err.Error()
 	}

-- 
2.48.1