From 96c0784f99e134156be8b751607aad1e78bbc094 Mon Sep 17 00:00:00 2001
From: Runxi Yu <me@runxiyu.org>
Date: Sat, 05 Apr 2025 17:41:25 +0800
Subject: [PATCH] HTTP: Replace if-else chain with switch

---
 http_handle_repo_raw.go  | 7 ++++---
 http_handle_repo_tree.go | 7 ++++---

diff --git a/http_handle_repo_raw.go b/http_handle_repo_raw.go
index 54ca931ba0721d173fe951db74595551c578bf10..ea2925c897f67f11f67648897ab921bc67e0ed5c 100644
--- a/http_handle_repo_raw.go
+++ b/http_handle_repo_raw.go
@@ -36,18 +36,19 @@ 		errorPage500(writer, params, err.Error())
 		return
 	}
 
-	if files != nil {
+	switch {
+	case files != nil:
 		params["files"] = files
 		params["readme_filename"] = "README.md"
 		params["readme"] = template.HTML("<p>README rendering here is WIP again</p>") // TODO
 		renderTemplate(writer, "repo_raw_dir", params)
-	} else if content != "" {
+	case content != "":
 		if redirectNoDir(writer, request) {
 			return
 		}
 		writer.Header().Set("Content-Type", "application/octet-stream")
 		fmt.Fprint(writer, content)
-	} else {
+	default:
 		errorPage500(writer, params, "Unknown error fetching repo raw data")
 	}
 }
diff --git a/http_handle_repo_tree.go b/http_handle_repo_tree.go
index d577f4842d2891626f627bdd42bea4d1918e0c8d..889406bade45ee7d8b908be6ffed75027fa9a982 100644
--- a/http_handle_repo_tree.go
+++ b/http_handle_repo_tree.go
@@ -37,16 +37,17 @@ 		errorPage500(writer, params, err.Error())
 		return
 	}
 
-	if files != nil {
+	switch {
+	case files != nil:
 		params["files"] = files
 		params["readme_filename"] = "README.md"
 		params["readme"] = template.HTML("<p>README rendering here is WIP again</p>") // TODO
 		renderTemplate(writer, "repo_tree_dir", params)
-	} else if content != "" {
+	case content != "":
 		rendered := renderHighlightedFile(pathSpec, content)
 		params["file_contents"] = rendered
 		renderTemplate(writer, "repo_tree_file", params)
-	} else {
+	default:
 		errorPage500(writer, params, "Unknown object type, something is seriously wrong")
 	}
 }

-- 
2.48.1