From a3a9719af3d648c90b049e94d7d446651d0d011b Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Mon, 10 Feb 2025 20:53:27 +0800 Subject: [PATCH] repo_tree: Fix URL and anchor issues --- git_misc.go | 3 ++- handle_repo_tree.go | 81 +++++++++++++++++++++++++++++++---------------------- resources.go | 5 ++++- template_funcs.go | 9 ++++++++- templates/repo_tree_dir.html | 6 +++--- diff --git a/git_misc.go b/git_misc.go index 4c8ea4d8b1c6e05a7c7c8ee4d7cd754de441ca83..64d1ff5649f536f05dbd494201192485e66594a1 100644 --- a/git_misc.go +++ b/git_misc.go @@ -3,6 +3,7 @@ import ( "errors" "path/filepath" + "strings" "github.com/go-git/go-git/v5" "github.com/go-git/go-git/v5/plumbing" @@ -29,7 +30,7 @@ display_git_tree_entry.Size, err = tree.Size(entry.Name) if err != nil { display_git_tree_entry.Size = 0 } - display_git_tree_entry.Name = entry.Name + display_git_tree_entry.Name = strings.TrimPrefix(entry.Name, "/") display_git_tree = append(display_git_tree, display_git_tree_entry) } return display_git_tree diff --git a/handle_repo_tree.go b/handle_repo_tree.go index 0782ce8aa15bbc83c67adac63b9ab3fe6e2832d3..8397a841f893e8f82183aacdb4ce6ebcecfdf31a 100644 --- a/handle_repo_tree.go +++ b/handle_repo_tree.go @@ -5,17 +5,20 @@ "bytes" "html/template" "net/http" "strings" + "path" chroma_formatters_html "github.com/alecthomas/chroma/v2/formatters/html" chroma_lexers "github.com/alecthomas/chroma/v2/lexers" chroma_styles "github.com/alecthomas/chroma/v2/styles" "github.com/go-git/go-git/v5/plumbing" + "github.com/go-git/go-git/v5/plumbing/object" ) func handle_repo_tree(w http.ResponseWriter, r *http.Request) { data := make(map[string]any) // TODO: Sanitize path values - ref_name, category_name, repo_name, path_spec := r.PathValue("ref"), r.PathValue("category_name"), r.PathValue("repo_name"), strings.TrimSuffix(r.PathValue("rest"), "/") + raw_path_spec := r.PathValue("rest") + ref_name, category_name, repo_name, path_spec := r.PathValue("ref"), r.PathValue("category_name"), r.PathValue("repo_name"), strings.TrimSuffix(raw_path_spec, "/") data["ref"], data["category_name"], data["repo_name"], data["path_spec"] = ref_name, category_name, repo_name, path_spec repo, err := open_git_repo(category_name, repo_name) if err != nil { @@ -39,43 +42,53 @@ _, _ = w.Write([]byte("Error getting file tree: " + err.Error())) return } - target, err := tree.Tree(path_spec) - if err != nil { - file, err := tree.File(path_spec) + var target *object.Tree + if path_spec == "" { + target = tree + } else { + target, err = tree.Tree(path_spec) if err != nil { - _, _ = w.Write([]byte("Error retrieving path: " + err.Error())) - return - } - file_contents, err := file.Contents() - if err != nil { - _, _ = w.Write([]byte("Error reading file: " + err.Error())) - return - } - lexer := chroma_lexers.Match(path_spec) - if lexer == nil { - lexer = chroma_lexers.Fallback - } - iterator, err := lexer.Tokenise(nil, file_contents) - if err != nil { - _, _ = w.Write([]byte("Error tokenizing code: " + err.Error())) - return - } - var formatted_unencapsulated bytes.Buffer - style := chroma_styles.Get("autumn") - formatter := chroma_formatters_html.New(chroma_formatters_html.WithClasses(true), chroma_formatters_html.TabWidth(8)) - err = formatter.Format(&formatted_unencapsulated, style, iterator) - if err != nil { - _, _ = w.Write([]byte("Error formatting code: " + err.Error())) + file, err := tree.File(path_spec) + if err != nil { + _, _ = w.Write([]byte("Error retrieving path: " + err.Error())) + return + } + file_contents, err := file.Contents() + if err != nil { + _, _ = w.Write([]byte("Error reading file: " + err.Error())) + return + } + lexer := chroma_lexers.Match(path_spec) + if lexer == nil { + lexer = chroma_lexers.Fallback + } + iterator, err := lexer.Tokenise(nil, file_contents) + if err != nil { + _, _ = w.Write([]byte("Error tokenizing code: " + err.Error())) + return + } + var formatted_unencapsulated bytes.Buffer + style := chroma_styles.Get("autumn") + formatter := chroma_formatters_html.New(chroma_formatters_html.WithClasses(true), chroma_formatters_html.TabWidth(8)) + err = formatter.Format(&formatted_unencapsulated, style, iterator) + if err != nil { + _, _ = w.Write([]byte("Error formatting code: " + err.Error())) + return + } + formatted_encapsulated := template.HTML(formatted_unencapsulated.Bytes()) + data["file_contents"] = formatted_encapsulated + + err = templates.ExecuteTemplate(w, "repo_tree_file", data) + if err != nil { + _, _ = w.Write([]byte("Error rendering template: " + err.Error())) + return + } return } - formatted_encapsulated := template.HTML(formatted_unencapsulated.Bytes()) - data["file_contents"] = formatted_encapsulated + } - err = templates.ExecuteTemplate(w, "repo_tree_file", data) - if err != nil { - _, _ = w.Write([]byte("Error rendering template: " + err.Error())) - return - } + if raw_path_spec[len(raw_path_spec) - 1] != '/' { + http.Redirect(w, r, path.Base(path_spec) + "/", http.StatusSeeOther) return } diff --git a/resources.go b/resources.go index afec157178189193e896dc9b67672d3df75f5a52..860971ca5ae55eab257cce24f52a3c32ed5b1c2d 100644 --- a/resources.go +++ b/resources.go @@ -13,7 +13,10 @@ var templates *template.Template func load_templates() (err error) { - templates, err = template.New("templates").Funcs(template.FuncMap{"first_line": first_line}).ParseFS(resources_fs, "templates/*") + templates, err = template.New("templates").Funcs(template.FuncMap{ + "first_line": first_line, + "base_name": base_name, + }).ParseFS(resources_fs, "templates/*") return err } diff --git a/template_funcs.go b/template_funcs.go index 3c5ca0bac49a15dfaf3015dfa8c353b95ac3c97f..1c6865072df8488e821297a7c3a56fb5d4c11407 100644 --- a/template_funcs.go +++ b/template_funcs.go @@ -1,8 +1,15 @@ package main -import "strings" +import ( + "path/filepath" + "strings" +) func first_line(s string) string { before, _, _ := strings.Cut(s, "\n") return before } + +func base_name (s string) string { + return filepath.Base(s) +} diff --git a/templates/repo_tree_dir.html b/templates/repo_tree_dir.html index cb5b26492c467d4f83a3038a29672646dda3d7b2..207fcaaa98296aa5361eb3febfef8483a33057ec 100644 --- a/templates/repo_tree_dir.html +++ b/templates/repo_tree_dir.html @@ -3,7 +3,7 @@ {{ template "head_common" . }} - {{ .category_name }}/repos/{{ .repo_name }}/{{ .path_spec }} – Lindenii Forge + {{ .category_name }}/repos/{{ .repo_name }}/{{ .path_spec }}{{ if ne .path_spec "" }}/{{ end }} – Lindenii Forge
@@ -11,7 +11,7 @@ @@ -25,7 +25,7 @@ {{- $path_spec := .path_spec }} {{- range .files }} - + {{- end }} -- 2.48.1
- /{{ .path_spec }}/ on {{ .ref }} + /{{ .path_spec }}{{ if ne .path_spec "" }}/{{ end }} on {{ .ref }}
{{ .Mode }}{{ .Name }}{{ if not .Is_file }}/{{ end }}{{ .Name }}{{ if not .Is_file }}/{{ end }} {{ .Size }}