Hi… I am well aware that this diff view is very suboptimal. It will be fixed when the refactored server comes along!
git_hooks_handle.go: Remove err_not_unixconn As this always suggests a programming mistake, we do not check the type assertion, causing it to panic if the types don't match.
package main import ( "bytes" "encoding/binary" "errors" "fmt" "net" "os" "syscall" ) var (
err_not_unixconn = errors.New("Not a unix connection")
err_get_fd = errors.New("Unable to get file descriptor")
err_get_ucred = errors.New("Failed getsockopt")
)
func hooks_handle_connection(conn net.Conn) {
defer conn.Close()
ucred, err := get_ucred(conn)
if err != nil {
conn.Write([]byte{1})
fmt.Fprintln(conn, "Unable to get peer credentials:", err.Error())
return
}
if ucred.Uid != uint32(os.Getuid()) {
conn.Write([]byte{1})
fmt.Fprintln(conn, "UID mismatch")
return
}
cookie := make([]byte, 64)
_, err = conn.Read(cookie)
if err != nil {
conn.Write([]byte{1})
fmt.Fprintln(conn, "Failed to read cookie:", err.Error())
return
}
deployer_chan, ok := hooks_cookie_deployer.Load(string(cookie))
if !ok {
conn.Write([]byte{1})
fmt.Fprintln(conn, "Invalid cookie")
return
}
var argc64 uint64
err = binary.Read(conn, binary.NativeEndian, &argc64)
if err != nil {
conn.Write([]byte{1})
fmt.Fprintln(conn, "Failed to read argc:", err.Error())
return
}
var args []string
for i := uint64(0); i < argc64; i++ {
var arg bytes.Buffer
for {
b := make([]byte, 1)
n, err := conn.Read(b)
if err != nil || n != 1 {
conn.Write([]byte{1})
fmt.Fprintln(conn, "Failed to read arg:", err.Error())
return
}
if b[0] == 0 {
break
}
arg.WriteByte(b[0])
}
args = append(args, arg.String())
}
callback := make(chan struct{})
deployer_chan <- hooks_cookie_deployer_return{
args: args,
callback: callback,
conn: conn,
}
<-callback
}
func serve_git_hooks(listener net.Listener) error {
for {
conn, err := listener.Accept()
if err != nil {
return err
}
go hooks_handle_connection(conn)
}
}
func get_ucred(conn net.Conn) (*syscall.Ucred, error) {
unix_conn := conn.(*net.UnixConn)
fd, err := unix_conn.File()
if err != nil {
return nil, err_get_fd
}
defer fd.Close()
ucred, err := syscall.GetsockoptUcred(int(fd.Fd()), syscall.SOL_SOCKET, syscall.SO_PEERCRED)
if err != nil {
return nil, err_get_ucred
}
return ucred, nil
}