From d5ce020645270e2c705dd66309f5ec81d8b1e3fd Mon Sep 17 00:00:00 2001
From: Runxi Yu <me@runxiyu.org>
Date: Sat, 05 Apr 2025 10:16:05 +0800
Subject: [PATCH] Makefile: Cleanup and utilize dependencies correctly

---
 .gitignore |  1 -
 Makefile   | 18 ++++++++----------
 version.go |  3 +++

diff --git a/.gitignore b/.gitignore
index a57474dd83205641e91e3fbeee926b821fd5e0eb..3c5206bef4feeeb9e65cf5f84052cd8b9f3eb4a8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,4 @@
 /forge
-/version.go
 /vendor
 /source.tar.gz
 *.c.BAK
diff --git a/Makefile b/Makefile
index 4c9b699e4a6c2adf69731eb2c03d483a46d3ae9b..1239426119a0373b93eb74504a21a25ce44d085a 100644
--- a/Makefile
+++ b/Makefile
@@ -1,15 +1,16 @@
 # SPDX-License-Identifier: AGPL-3.0-only
 # SPDX-FileCopyrightText: Copyright (c) 2025 Runxi Yu <https://runxiyu.org>
 
-.PHONY: clean version.go man source.tar.gz
+.PHONY: clean
 
 CFLAGS = -Wall -Wextra -pedantic -std=c99 -D_GNU_SOURCE
 MAN_PAGES = lindenii-forge.5 lindenii-forge-hookc.1 lindenii-forge.1 lindenii-forge-mail.5
 
-forge: source.tar.gz version.go hookc/*.c hookc/hookc git2d/git2d man # TODO
-	go build .
+VERSION = $(shell git describe --tags --always --dirty)
+SOURCE_FILES = $(shell git ls-files)
 
-man: $(MAN_PAGES:%=man/%.html) $(MAN_PAGES:%=man/%.txt)
+forge: source.tar.gz hookc/hookc git2d/git2d $(MAN_PAGES:%=man/%.html) $(MAN_PAGES:%=man/%.txt) $(SOURCE_FILES)
+	go build -o forge -ldflags="-X 'main.VERSION=$(VERSION)'" .
 
 man/%.html: man/%
 	mandoc -Thtml -O style=./mandoc.css $< > $@
@@ -22,15 +23,12 @@
 hookc/hookc:
 
 git2d/git2d: git2d/main.c git2d/bare.c git2d/utf8.c
-	$(CC) $(CFLAGS) -o git2d/git2d $^ `pkg-config --cflags --libs libgit2` -lpthread 
-
-version.go:
-	printf 'package main\n\nconst VERSION = "%s"\n' `git describe --tags --always --dirty` > $@
+	$(CC) $(CFLAGS) -o git2d/git2d $^ $(shell pkg-config --cflags --libs libgit2) -lpthread
 
 clean:
-	$(RM) forge version.go vendor
+	rm -rf forge vendor man/*.html man/*.txt utils/colb hookc/hookc git2d/git2d source.tar.gz */*.o
 
-source.tar.gz:
+source.tar.gz: $(SOURCE_FILES)
 	rm -f source.tar.gz
 	go mod vendor
 	git ls-files -z | xargs -0 tar -czf source.tar.gz vendor
diff --git a/version.go b/version.go
new file mode 100644
index 0000000000000000000000000000000000000000..bfa4b96758e40bfc5d9a14ad8eba4b209c335924
--- /dev/null
+++ b/version.go
@@ -0,0 +1,3 @@
+package main
+
+var VERSION = "unknown"

-- 
2.48.1