From e7ff49a84c840c915774193737aaa8af4e885bf3 Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Wed, 02 Apr 2025 10:50:45 +0800 Subject: [PATCH] Git: Fix command leak (need cmd.Wait()) --- git_plumbing.go | 6 ++++++ diff --git a/git_plumbing.go b/git_plumbing.go index 9386ea99db706891f9818f3e1158be34079ee330..6adaf5a7a4227a2ae511d7ad087ad119f2a00f0d 100644 --- a/git_plumbing.go +++ b/git_plumbing.go @@ -60,6 +60,9 @@ cmd.Stdout = &out if err := cmd.Run(); err != nil { return "", err } + if err := cmd.Wait(); err != nil { + return "", err + } return strings.TrimSpace(out.String()), nil } @@ -73,6 +76,9 @@ cmd.Env = append(os.Environ(), "GIT_DIR="+repoPath) var out bytes.Buffer cmd.Stdout = &out if err := cmd.Run(); err != nil { + return err + } + if err := cmd.Wait(); err != nil { return err } data := out.Bytes() -- 2.48.1