Lindenii Project Forge
Commit info | |
---|---|
ID | 7f9705a29c29b77f9049f2d1222a2d08530fc225 |
Author | Runxi Yu<me@runxiyu.org> |
Author date | Wed, 19 Feb 2025 17:08:14 +0800 |
Committer | Runxi Yu<me@runxiyu.org> |
Committer date | Wed, 19 Feb 2025 17:08:14 +0800 |
Actions | Get patch |
hooks: Use ssh stderr directly instead of going through hook
package main import ( "bytes" "encoding/binary" "errors" "fmt" "io" "net" "os" "path/filepath" "strings" "syscall" "github.com/go-git/go-git/v5" "github.com/go-git/go-git/v5/plumbing" ) var ( err_get_fd = errors.New("unable to get file descriptor") err_get_ucred = errors.New("failed getsockopt") ) // hooks_handle_connection handles a connection from git_hooks_client via the // unix socket. func hooks_handle_connection(conn net.Conn) { defer conn.Close() // There aren't reasonable cases where someone would run this as // another user. ucred, err := get_ucred(conn) if err != nil { if _, err := conn.Write([]byte{1}); err != nil { return } fmt.Fprintln(conn, "Unable to get peer credentials:", err.Error()) return } if ucred.Uid != uint32(os.Getuid()) { if _, err := conn.Write([]byte{1}); err != nil { return } fmt.Fprintln(conn, "UID mismatch") return } cookie := make([]byte, 64) _, err = conn.Read(cookie) if err != nil { if _, err := conn.Write([]byte{1}); err != nil { return } fmt.Fprintln(conn, "Failed to read cookie:", err.Error()) return } pack_to_hook, ok := pack_to_hook_by_cookie.Load(string(cookie)) if !ok { if _, err := conn.Write([]byte{1}); err != nil { return } fmt.Fprintln(conn, "Invalid handler cookie") return }
var argc64 uint64 err = binary.Read(conn, binary.NativeEndian, &argc64) if err != nil { if _, err := conn.Write([]byte{1}); err != nil { return
ssh_stderr := pack_to_hook.session.Stderr() hook_return_value := func() byte { var argc64 uint64 err = binary.Read(conn, binary.NativeEndian, &argc64) if err != nil { fmt.Fprintln(ssh_stderr, "Failed to read argc:", err.Error()) return 1
}
fmt.Fprintln(conn, "Failed to read argc:", err.Error()) return } var args []string for i := uint64(0); i < argc64; i++ { var arg bytes.Buffer for { b := make([]byte, 1) n, err := conn.Read(b) if err != nil || n != 1 { if _, err := conn.Write([]byte{1}); err != nil { return
var args []string for i := uint64(0); i < argc64; i++ { var arg bytes.Buffer for { b := make([]byte, 1) n, err := conn.Read(b) if err != nil || n != 1 { fmt.Fprintln(ssh_stderr, "Failed to read arg:", err.Error()) return 1 } if b[0] == 0 { break
}
fmt.Fprintln(conn, "Failed to read arg:", err.Error()) return
arg.WriteByte(b[0])
}
if b[0] == 0 { break } arg.WriteByte(b[0])
args = append(args, arg.String())
}
args = append(args, arg.String()) }
var stdin bytes.Buffer _, err = io.Copy(&stdin, conn) if err != nil { fmt.Fprintln(conn, "Failed to read to the stdin buffer:", err.Error()) } switch filepath.Base(args[0]) { case "pre-receive": if pack_to_hook.direct_access { if _, err := conn.Write([]byte{0}); err != nil { return } } else { all_ok := true messages := make([]string, 0)
var stdin bytes.Buffer _, err = io.Copy(&stdin, conn) if err != nil { fmt.Fprintln(conn, "Failed to read to the stdin buffer:", err.Error()) }
for { line, err := stdin.ReadString('\n') if errors.Is(err, io.EOF) { break } line = line[:len(line)-1]
switch filepath.Base(args[0]) { case "pre-receive": if pack_to_hook.direct_access { return 0 } else { all_ok := true for { line, err := stdin.ReadString('\n') if errors.Is(err, io.EOF) { break } line = line[:len(line)-1]
old_oid, rest, found := strings.Cut(line, " ") if !found { if _, err := conn.Write([]byte{1}); err != nil { return
old_oid, rest, found := strings.Cut(line, " ") if !found { fmt.Fprintln(ssh_stderr, "Invalid pre-receive line:", line) return 1
}
fmt.Fprintln(conn, "Invalid pre-receive line:", line) break }
new_oid, ref_name, found := strings.Cut(rest, " ") if !found { if _, err := conn.Write([]byte{1}); err != nil { return
new_oid, ref_name, found := strings.Cut(rest, " ") if !found { fmt.Fprintln(ssh_stderr, "Invalid pre-receive line:", line) return 1
}
fmt.Fprintln(conn, "Invalid pre-receive line:", line) break }
if strings.HasPrefix(ref_name, "refs/heads/contrib/") { if all_zero_num_string(old_oid) { // New branch messages = append(messages, "Acceptable push to new contrib branch: "+ref_name) // TODO: Create a merge request. If that fails, // we should just reject this entire push // immediately. } else { // Existing contrib branch // TODO: Check if the current user is authorized // to push to this contrib branch. repo, err := git.PlainOpen(pack_to_hook.repo_path) if err != nil { if _, err := conn.Write([]byte{1}); err != nil { return
if strings.HasPrefix(ref_name, "refs/heads/contrib/") { if all_zero_num_string(old_oid) { // New branch fmt.Fprintln(ssh_stderr, "Acceptable push to new contrib branch: "+ref_name) // TODO: Create a merge request. If that fails, // we should just reject this entire push // immediately. } else { // Existing contrib branch // TODO: Check if the current user is authorized // to push to this contrib branch. repo, err := git.PlainOpen(pack_to_hook.repo_path) if err != nil { fmt.Fprintln(ssh_stderr, "Daemon failed to open repo:", err.Error()) return 1
}
fmt.Fprintln(conn, "Daemon failed to open repo:", err.Error()) return }
old_hash := plumbing.NewHash(old_oid) fmt.Println(old_hash)
old_hash := plumbing.NewHash(old_oid)
old_commit, err := repo.CommitObject(old_hash) if err != nil { if _, err := conn.Write([]byte{1}); err != nil { return
old_commit, err := repo.CommitObject(old_hash) if err != nil { fmt.Fprintln(ssh_stderr, "Daemon failed to get old commit:", err.Error()) return 1
}
fmt.Fprintln(conn, "Daemon failed to get old commit:", err.Error()) return }
// Potential BUG: I'm not sure if new_commit is guaranteed to be // detectable as they haven't been merged into the main repo's // objects yet. But it seems to work, and I don't think there's // any reason for this to only work intermitently. new_hash := plumbing.NewHash(new_oid) new_commit, err := repo.CommitObject(new_hash) if err != nil { fmt.Fprintln(ssh_stderr, "Daemon failed to get new commit:", err.Error()) return 1 }
// Potential BUG: I'm not sure if new_commit is guaranteed to be // detectable as they haven't been merged into the main repo's // objects yet. But it seems to work, and I don't think there's // any reason for this to only work intermitently. new_hash := plumbing.NewHash(new_oid) new_commit, err := repo.CommitObject(new_hash) if err != nil { if _, err := conn.Write([]byte{1}); err != nil { return
is_ancestor, err := old_commit.IsAncestor(new_commit) if err != nil { fmt.Fprintln(ssh_stderr, "Daemon failed to check if old commit is ancestor:", err.Error()) return 1
}
fmt.Fprintln(conn, "Daemon failed to get new commit:", err.Error()) return }
is_ancestor, err := old_commit.IsAncestor(new_commit) if err != nil { if _, err := conn.Write([]byte{1}); err != nil { return
if !is_ancestor { // TODO: Create MR snapshot ref instead all_ok = false fmt.Fprintln(ssh_stderr, "Rejecting force push to contrib branch: "+ref_name) continue
}
fmt.Fprintln(conn, "Daemon failed to check if old commit is ancestor:", err.Error()) return }
if !is_ancestor { // TODO: Create MR snapshot ref instead all_ok = false messages = append(messages, "Rejecting force push to contrib branch: "+ref_name) continue
fmt.Fprintln(ssh_stderr, "Acceptable push to existing contrib branch: "+ref_name)
}
messages = append(messages, "Acceptable push to existing contrib branch: "+ref_name)
} else { // Non-contrib branch all_ok = false fmt.Fprintln(ssh_stderr, "Rejecting push to non-contrib branch: "+ref_name)
}
} else { // Non-contrib branch all_ok = false messages = append(messages, "Rejecting push to non-contrib branch: "+ref_name)
}
}
if all_ok { if _, err := conn.Write([]byte{0}); err != nil { return } } else { if _, err := conn.Write([]byte{1}); err != nil { return
if all_ok { return 0 } else { return 1
} }
for _, message := range messages { fmt.Fprintln(conn, message) } } default: if _, err := conn.Write([]byte{1}); err != nil { return
default: fmt.Fprintln(ssh_stderr, "Invalid hook:", args[0]) return 1
}
fmt.Fprintln(conn, "Invalid hook:", args[0]) }
}() conn.Write([]byte{hook_return_value})
} func serve_git_hooks(listener net.Listener) error { for { conn, err := listener.Accept() if err != nil { return err } go hooks_handle_connection(conn) } } func get_ucred(conn net.Conn) (*syscall.Ucred, error) { unix_conn := conn.(*net.UnixConn) fd, err := unix_conn.File() if err != nil { return nil, err_get_fd } defer fd.Close() ucred, err := syscall.GetsockoptUcred(int(fd.Fd()), syscall.SOL_SOCKET, syscall.SO_PEERCRED) if err != nil { return nil, err_get_ucred } return ucred, nil } func all_zero_num_string(s string) bool { for _, r := range s { if r != '0' { return false } } return true }
package main import ( "errors" "fmt" "os" "os/exec" glider_ssh "github.com/gliderlabs/ssh" "go.lindenii.runxiyu.org/lindenii-common/cmap" ) var err_unauthorized_push = errors.New("you are not authorized to push to this repository") type pack_to_hook_t struct {
session *glider_ssh.Session
session glider_ssh.Session
pubkey string direct_access bool repo_path string } var pack_to_hook_by_cookie = cmap.Map[string, pack_to_hook_t]{} // ssh_handle_receive_pack handles attempts to push to repos. func ssh_handle_receive_pack(session glider_ssh.Session, pubkey string, repo_identifier string) (err error) { // Here "access" means direct maintainer access. access=false doesn't // necessarily mean the push is declined. This decision is delegated to // the pre-receive hook, which is then handled by git_hooks_handle.go // while being aware of the refs to be updated. repo_path, access, err := get_repo_path_perms_from_ssh_path_pubkey(session.Context(), repo_identifier, pubkey) if err != nil { return err } cookie, err := random_urlsafe_string(16) if err != nil { fmt.Fprintln(session.Stderr(), "Error while generating cookie:", err) } pack_to_hook_by_cookie.Store(cookie, pack_to_hook_t{
session: &session,
session: session,
pubkey: pubkey, direct_access: access, repo_path: repo_path, }) defer pack_to_hook_by_cookie.Delete(cookie) // The Delete won't execute until proc.Wait returns unless something // horribly wrong such as a panic occurs. proc := exec.CommandContext(session.Context(), "git-receive-pack", repo_path) proc.Env = append(os.Environ(), "LINDENII_FORGE_HOOKS_SOCKET_PATH="+config.Hooks.Socket, "LINDENII_FORGE_HOOKS_COOKIE="+cookie, ) proc.Stdin = session proc.Stdout = session proc.Stderr = session.Stderr() err = proc.Start() if err != nil { fmt.Fprintln(session.Stderr(), "Error while starting process:", err) return err } err = proc.Wait() if exitError, ok := err.(*exec.ExitError); ok { fmt.Fprintln(session.Stderr(), "Process exited with error", exitError.ExitCode()) } else if err != nil { fmt.Fprintln(session.Stderr(), "Error while waiting for process:", err) } return err }