Lindenii Project Forge
Commit info | |
---|---|
ID | a9d5e405fd9334602c8c74b18558fd0db54a4036 |
Author | Runxi Yu<me@runxiyu.org> |
Author date | Thu, 13 Feb 2025 22:58:37 +0800 |
Committer | Runxi Yu<me@runxiyu.org> |
Committer date | Thu, 13 Feb 2025 22:58:37 +0800 |
Actions | Get patch |
http_{server,handle_login}.go: Fix missing error handling
package main import ( "crypto/rand" "encoding/base64" "errors" "fmt" "net/http" "time" "github.com/alexedwards/argon2id" "github.com/jackc/pgx/v5" ) func handle_login(w http.ResponseWriter, r *http.Request, params map[string]any) { if r.Method != "POST" { err := templates.ExecuteTemplate(w, "login", params) if err != nil { http.Error(w, "Error rendering template: "+err.Error(), http.StatusInternalServerError) } return } var user_id int username := r.PostFormValue("username") password := r.PostFormValue("password") var password_hash string err := database.QueryRow(r.Context(), "SELECT id, password FROM users WHERE username = $1", username).Scan(&user_id, &password_hash) if err != nil { if errors.Is(err, pgx.ErrNoRows) { params["login_error"] = "Unknown username" err := templates.ExecuteTemplate(w, "login", params) if err != nil { http.Error(w, "Error rendering template: "+err.Error(), http.StatusInternalServerError) } return } http.Error(w, "Error querying user information: "+err.Error(), http.StatusInternalServerError) return } match, err := argon2id.ComparePasswordAndHash(password, password_hash) if err != nil { http.Error(w, "Error comparing password and hash: "+err.Error(), http.StatusInternalServerError) return } if !match { params["login_error"] = "Invalid password" err := templates.ExecuteTemplate(w, "login", params) if err != nil { http.Error(w, "Error rendering template: "+err.Error(), http.StatusInternalServerError) return } return } cookie_value, err := random_urlsafe_string(16)
if err != nil { http.Error(w, "Error getting random string: "+err.Error(), http.StatusInternalServerError) return }
now := time.Now() expiry := now.Add(time.Duration(config.HTTP.CookieExpiry) * time.Second) cookie := http.Cookie{ Name: "session", Value: cookie_value, SameSite: http.SameSiteLaxMode, HttpOnly: true, Secure: false, // TODO Expires: expiry, Path: "/", // TODO: Expire } http.SetCookie(w, &cookie) _, err = database.Exec(r.Context(), "INSERT INTO sessions (user_id, session_id) VALUES ($1, $2)", user_id, cookie_value) if err != nil { http.Error(w, "Error inserting session: "+err.Error(), http.StatusInternalServerError) return } http.Redirect(w, r, "/", http.StatusSeeOther) } func random_urlsafe_string(sz int) (string, error) { r := make([]byte, 3*sz) _, err := rand.Read(r) if err != nil { return "", fmt.Errorf("error generating random string: %w", err) } return base64.RawURLEncoding.EncodeToString(r), nil }
package main import ( "errors" "fmt" "net/http" "strconv" "strings" "go.lindenii.runxiyu.org/lindenii-common/clog"
"github.com/jackc/pgx/v5"
) type http_router_t struct{} func (router *http_router_t) ServeHTTP(w http.ResponseWriter, r *http.Request) { clog.Debug("Incoming HTTP: " + r.RemoteAddr + " " + r.Method + " " + r.RequestURI) segments, _, err := parse_request_uri(r.RequestURI) if err != nil { http.Error(w, err.Error(), http.StatusBadRequest) return } non_empty_last_segments_len := len(segments) dir_mode := false if segments[len(segments)-1] == "" { non_empty_last_segments_len-- dir_mode = true } if segments[0] == ":" { if len(segments) < 2 { http.Error(w, "Blank system endpoint", http.StatusNotFound) return } else if len(segments) == 2 && !dir_mode { http.Redirect(w, r, r.URL.Path+"/", http.StatusSeeOther) return } switch segments[1] { case "static": static_handler.ServeHTTP(w, r) return case "source": source_handler.ServeHTTP(w, r) return } } params := make(map[string]any) params["global"] = global_data
var _user_id int
var _user_id int // 0 for none
_user_id, params["username"], err = get_user_info_from_request(r)
if errors.Is(err, http.ErrNoCookie) { } else if errors.Is(err, pgx.ErrNoRows) { } else if err != nil { http.Error(w, "Error getting user info from request: "+err.Error(), http.StatusInternalServerError) return }
if _user_id == 0 { params["user_id"] = "" } else { params["user_id"] = strconv.Itoa(_user_id) } if segments[0] == ":" { switch segments[1] { case "login": handle_login(w, r, params) return case "users": handle_users(w, r, params) return default: http.Error(w, fmt.Sprintf("Unknown system module type: %s", segments[1]), http.StatusNotFound) return } } separator_index := -1 for i, part := range segments { if part == ":" { separator_index = i break } } switch { case non_empty_last_segments_len == 0: handle_index(w, r, params) case separator_index == -1: http.Error(w, "Group indexing hasn't been implemented yet", http.StatusNotImplemented) case non_empty_last_segments_len == separator_index+1: http.Error(w, "Group root hasn't been implemented yet", http.StatusNotImplemented) case non_empty_last_segments_len == separator_index+2: if !dir_mode { http.Redirect(w, r, r.URL.Path+"/", http.StatusSeeOther) return } module_type := segments[separator_index+1] params["group_name"] = segments[0] switch module_type { case "repos": handle_group_repos(w, r, params) default: http.Error(w, fmt.Sprintf("Unknown module type: %s", module_type), http.StatusNotFound) } default: module_type := segments[separator_index+1] module_name := segments[separator_index+2] params["group_name"] = segments[0] switch module_type { case "repos": params["repo_name"] = module_name // TODO: subgroups if non_empty_last_segments_len == separator_index+3 { if !dir_mode { http.Redirect(w, r, r.URL.Path+"/", http.StatusSeeOther) return } handle_repo_index(w, r, params) return } repo_feature := segments[separator_index+3] switch repo_feature { case "info": handle_repo_info(w, r, params) case "tree": params["rest"] = strings.Join(segments[separator_index+4:], "/") handle_repo_tree(w, r, params) case "raw": params["rest"] = strings.Join(segments[separator_index+4:], "/") handle_repo_raw(w, r, params) case "log": if non_empty_last_segments_len != separator_index+5 { http.Error(w, "Too many parameters", http.StatusBadRequest) return } if dir_mode { http.Redirect(w, r, strings.TrimSuffix(r.URL.Path, "/"), http.StatusSeeOther) return } params["ref"] = segments[separator_index+4] handle_repo_log(w, r, params) case "commit": if dir_mode { http.Redirect(w, r, strings.TrimSuffix(r.URL.Path, "/"), http.StatusSeeOther) return } params["commit_id"] = segments[separator_index+4] handle_repo_commit(w, r, params) default: http.Error(w, fmt.Sprintf("Unknown repo feature: %s", repo_feature), http.StatusNotFound) } default: http.Error(w, fmt.Sprintf("Unknown module type: %s", module_type), http.StatusNotFound) } } } var err_bad_request = errors.New("Bad Request")